[Saga-devel] saga SVN commit 3401: /trunk/adaptors/default/job/

[Andre Merzky]

Quoting [Ole Christian Weidner] (Jan 29 2009):
> Andre,
> 
> I don't understand the changes you made. Why did you replace "execve"  
> with "execv"? What was the problem there? The error seemed to be some  
> sort of race condition ?!?

no race condition - I needed env set corectly for local
jobs, so I echanged execv with execve.  However, I did
create the env pointer incorrectly.  Instead of fixing that,
which involves a lot of strdups etc, I just move putenv now:
that is done after the fork, and env is local to the
process, so that is cleaner.

Anyway, the earlier invalid env caused many programs to
simply fail - env is ok now, so programs work, so tests
work.

Cheers, Andre.

> 
> Cheers,
> Ole
> 
> On Jan 29, 2009, at 10:57 AM, amerzky at cct.lsu.edu wrote:
> 
> >User: amerzky
> >Date: 2009/01/29 10:57 AM
> >
> >Modified:
> >/trunk/adaptors/default/job/
> > impl_posix_job.cpp
> >
> >Log:
> >simplify and fix.  This should make buildbot happy.
> >A
> 
> _______________________________________________
> saga-devel mailing list
> saga-devel at cct.lsu.edu
> https://mail.cct.lsu.edu/mailman/listinfo/saga-devel



-- 
Nothing is ever easy.